Removed nasty hack in Behat tests as it is not needed anymore.

CHANGES.md

@@ -6,6 +6,7 @@ Changes
 
 ### Unreleased
 
+* 2020-08-26 - Removed nasty hack in Behat tests as it is not needed anymore.
 * 2020-08-25 - Changed calling of footer and footnote layouts to fix behat issues.
 * 2020-08-25 - Fixed favicon 404 Error when no individual favicon is uploaded in Boost Campus.
 * 2020-08-19 - Added capability theme/boost_campus:viewhintinhiddencourse for setting showhintcoursehidden.

tests/behat/theme_boost_campus_additional_layout_settings.feature

@@ -14,16 +14,6 @@ Feature: Configuring the theme_boost_campus plugin for the "Additional Layout Se
     And the following "course enrolments" exist:
       | user     | course | role           |
       | teacher1 | C1     | editingteacher |
-    # There is a nasty bug with Behat-testing this theme that the footer is not displayed until the settings
-    # of the theme are stored manually. It seems not to be sufficient to just rely on the default settings being
-    # stored during the installation of the theme. Until we find the root of this bug, we circumvent it by setting the
-    # brand color manually and within this process making sure that all settings are really stored to the database.
-    And I log in as "admin"
-    And I navigate to "Appearance > Boost Campus" in site administration
-    And I click on "General settings" "link"
-    And I set the field "id_s_theme_boost_campus_brandcolor" to "#7a99ac"
-    And I press "Save changes"
-    And I log out
 
   @javascript @_file_upload
   Scenario: Add "Image area items"

tests/behat/theme_boost_campus_advanced_settings.feature

@@ -16,16 +16,6 @@ Feature: Configuring the theme_boost_campus plugin for the "Advanced settings" t
       | user     | course | role           |
       | teacher1 | C1     | editingteacher |
       | student1 | C1     | student        |
-    # There is a nasty bug with Behat-testing this theme that the footer is not displayed until the settings
-    # of the theme are stored manually. It seems not to be sufficient to just rely on the default settings being
-    # stored during the installation of the theme. Until we find the root of this bug, we circumvent it by setting the
-    # brand color manually and within this process making sure that all settings are really stored to the database.
-    And I log in as "admin"
-    And I navigate to "Appearance > Boost Campus" in site administration
-    And I click on "General settings" "link"
-    And I set the field "id_s_theme_boost_campus_brandcolor" to "#7a99ac"
-    And I press "Save changes"
-    And I log out
 
   # This is derivated from theme Boost and should be covered there with tests
   # Scenario: Add "Raw initial SCSS"

tests/behat/theme_boost_campus_course_layout_settings.feature

@@ -16,16 +16,6 @@ Feature: Configuring the theme_boost_campus plugin for the "Course Layout settin
       | user     | course | role           |
       | teacher1 | C1     | editingteacher |
       | student1 | C1     | student        |
-    # There is a nasty bug with Behat-testing this theme that the footer is not displayed until the settings
-    # of the theme are stored manually. It seems not to be sufficient to just rely on the default settings being
-    # stored during the installation of the theme. Until we find the root of this bug, we circumvent it by setting the
-    # brand color manually and within this process making sure that all settings are really stored to the database.
-    And I log in as "admin"
-    And I navigate to "Appearance > Boost Campus" in site administration
-    And I click on "General settings" "link"
-    And I set the field "id_s_theme_boost_campus_brandcolor" to "#7a99ac"
-    And I press "Save changes"
-    And I log out
 
   Scenario: Enable "Section 0: Title"
     Given the following config values are set as admin:

tests/behat/theme_boost_campus_design_settings.feature

@@ -14,16 +14,6 @@ Feature: Configuring the theme_boost_campus plugin for the "Design Settings" tab
     And the following "course enrolments" exist:
       | user     | course | role           |
       | teacher1 | C1     | editingteacher |
-    # There is a nasty bug with Behat-testing this theme that the footer is not displayed until the settings
-    # of the theme are stored manually. It seems not to be sufficient to just rely on the default settings being
-    # stored during the installation of the theme. Until we find the root of this bug, we circumvent it by setting the
-    # brand color manually and within this process making sure that all settings are really stored to the database.
-    And I log in as "admin"
-    And I navigate to "Appearance > Boost Campus" in site administration
-    And I click on "General settings" "link"
-    And I set the field "id_s_theme_boost_campus_brandcolor" to "#7a99ac"
-    And I press "Save changes"
-    And I log out
 
   @javascript @_file_upload
   # The setting is designed to display multiple login background images in a random order.

tests/behat/theme_boost_campus_footer_layout_settings.feature

@@ -14,16 +14,6 @@ Feature: Configuring the theme_boost_campus plugin for the "Footer Layout Settin
     And the following "course enrolments" exist:
       | user     | course | role           |
       | teacher1 | C1     | editingteacher |
-    # There is a nasty bug with Behat-testing this theme that the footer is not displayed until the settings
-    # of the theme are stored manually. It seems not to be sufficient to just rely on the default settings being
-    # stored during the installation of the theme. Until we find the root of this bug, we circumvent it by setting the
-    # brand color manually and within this process making sure that all settings are really stored to the database.
-    And I log in as "admin"
-    And I navigate to "Appearance > Boost Campus" in site administration
-    And I click on "General settings" "link"
-    And I set the field "id_s_theme_boost_campus_brandcolor" to "#7a99ac"
-    And I press "Save changes"
-    And I log out
 
   # This scenario needs full browser support only for this Behat test to pass, otherwise javascript would not be needed.
   @javascript

tests/behat/theme_boost_campus_general_settings.feature

@@ -4,18 +4,6 @@ Feature: Configuring the theme_boost_campus plugin for the "General settings" ta
   As admin
   I need to be able to configure the theme Boost Campus plugin
 
-  Background:
-    # There is a nasty bug with Behat-testing this theme that the footer is not displayed until the settings
-    # of the theme are stored manually. It seems not to be sufficient to just rely on the default settings being
-    # stored during the installation of the theme. Until we find the root of this bug, we circumvent it by setting the
-    # brand color manually and within this process making sure that all settings are really stored to the database.
-    And I log in as "admin"
-    And I navigate to "Appearance > Boost Campus" in site administration
-    And I click on "General settings" "link"
-    And I set the field "id_s_theme_boost_campus_brandcolor" to "#7a99ac"
-    And I press "Save changes"
-    And I log out
-
   # This is derivated from theme Boost and should be covered there with tests
   #  Scenario: Change "Theme preset"
 

tests/behat/theme_boost_campus_info_banner_settings.feature

@@ -14,16 +14,6 @@ Feature: Configuring the theme_boost_campus plugin for the "Info banner Settings
     And the following "course enrolments" exist:
       | user     | course | role           |
       | teacher1 | C1     | editingteacher |
-    # There is a nasty bug with Behat-testing this theme that the footer is not displayed until the settings
-    # of the theme are stored manually. It seems not to be sufficient to just rely on the default settings being
-    # stored during the installation of the theme. Until we find the root of this bug, we circumvent it by setting the
-    # brand color manually and within this process making sure that all settings are really stored to the database.
-    And I log in as "admin"
-    And I navigate to "Appearance > Boost Campus" in site administration
-    And I click on "General settings" "link"
-    And I set the field "id_s_theme_boost_campus_brandcolor" to "#7a99ac"
-    And I press "Save changes"
-    And I log out
 
   Scenario: Display perpetual info banner on all available pages
     Given the following config values are set as admin: