diff --git a/CHANGES.md b/CHANGES.md index 208342776a01ba36730779808ff7832984b9362f..dd7cdc3768c98de9546a0c15f733da2b0934e81e 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -6,6 +6,7 @@ Changes ### Unreleased +* 2020-08-26 - Removed nasty hack in Behat tests as it is not needed anymore. * 2020-08-25 - Changed calling of footer and footnote layouts to fix behat issues. * 2020-08-25 - Fixed favicon 404 Error when no individual favicon is uploaded in Boost Campus. * 2020-08-19 - Added capability theme/boost_campus:viewhintinhiddencourse for setting showhintcoursehidden. diff --git a/tests/behat/theme_boost_campus_additional_layout_settings.feature b/tests/behat/theme_boost_campus_additional_layout_settings.feature index 3361201453c4f9125822d3b568bddab1421715e9..0dbafc15d19ce20f51e4d6c051f58da4ceef8915 100644 --- a/tests/behat/theme_boost_campus_additional_layout_settings.feature +++ b/tests/behat/theme_boost_campus_additional_layout_settings.feature @@ -14,16 +14,6 @@ Feature: Configuring the theme_boost_campus plugin for the "Additional Layout Se And the following "course enrolments" exist: | user | course | role | | teacher1 | C1 | editingteacher | - # There is a nasty bug with Behat-testing this theme that the footer is not displayed until the settings - # of the theme are stored manually. It seems not to be sufficient to just rely on the default settings being - # stored during the installation of the theme. Until we find the root of this bug, we circumvent it by setting the - # brand color manually and within this process making sure that all settings are really stored to the database. - And I log in as "admin" - And I navigate to "Appearance > Boost Campus" in site administration - And I click on "General settings" "link" - And I set the field "id_s_theme_boost_campus_brandcolor" to "#7a99ac" - And I press "Save changes" - And I log out @javascript @_file_upload Scenario: Add "Image area items" diff --git a/tests/behat/theme_boost_campus_advanced_settings.feature b/tests/behat/theme_boost_campus_advanced_settings.feature index 6df8b0d48369629d5ac42c7eebbc3a1b72bee296..28a96c9efa0d281958d3f5c46024cbc42d52b5f3 100644 --- a/tests/behat/theme_boost_campus_advanced_settings.feature +++ b/tests/behat/theme_boost_campus_advanced_settings.feature @@ -16,16 +16,6 @@ Feature: Configuring the theme_boost_campus plugin for the "Advanced settings" t | user | course | role | | teacher1 | C1 | editingteacher | | student1 | C1 | student | - # There is a nasty bug with Behat-testing this theme that the footer is not displayed until the settings - # of the theme are stored manually. It seems not to be sufficient to just rely on the default settings being - # stored during the installation of the theme. Until we find the root of this bug, we circumvent it by setting the - # brand color manually and within this process making sure that all settings are really stored to the database. - And I log in as "admin" - And I navigate to "Appearance > Boost Campus" in site administration - And I click on "General settings" "link" - And I set the field "id_s_theme_boost_campus_brandcolor" to "#7a99ac" - And I press "Save changes" - And I log out # This is derivated from theme Boost and should be covered there with tests # Scenario: Add "Raw initial SCSS" diff --git a/tests/behat/theme_boost_campus_course_layout_settings.feature b/tests/behat/theme_boost_campus_course_layout_settings.feature index 613c9232d7a2fe878d16863a56accd3048fd1b07..53a64693f9b50925b56c39668267d3392e7dbad7 100644 --- a/tests/behat/theme_boost_campus_course_layout_settings.feature +++ b/tests/behat/theme_boost_campus_course_layout_settings.feature @@ -16,16 +16,6 @@ Feature: Configuring the theme_boost_campus plugin for the "Course Layout settin | user | course | role | | teacher1 | C1 | editingteacher | | student1 | C1 | student | - # There is a nasty bug with Behat-testing this theme that the footer is not displayed until the settings - # of the theme are stored manually. It seems not to be sufficient to just rely on the default settings being - # stored during the installation of the theme. Until we find the root of this bug, we circumvent it by setting the - # brand color manually and within this process making sure that all settings are really stored to the database. - And I log in as "admin" - And I navigate to "Appearance > Boost Campus" in site administration - And I click on "General settings" "link" - And I set the field "id_s_theme_boost_campus_brandcolor" to "#7a99ac" - And I press "Save changes" - And I log out Scenario: Enable "Section 0: Title" Given the following config values are set as admin: diff --git a/tests/behat/theme_boost_campus_design_settings.feature b/tests/behat/theme_boost_campus_design_settings.feature index c55cb8dc5457c609baaf6833995982cbdf5eaebb..8f503d5dd72907a3cb634b4a46a8d426112c89fe 100644 --- a/tests/behat/theme_boost_campus_design_settings.feature +++ b/tests/behat/theme_boost_campus_design_settings.feature @@ -14,16 +14,6 @@ Feature: Configuring the theme_boost_campus plugin for the "Design Settings" tab And the following "course enrolments" exist: | user | course | role | | teacher1 | C1 | editingteacher | - # There is a nasty bug with Behat-testing this theme that the footer is not displayed until the settings - # of the theme are stored manually. It seems not to be sufficient to just rely on the default settings being - # stored during the installation of the theme. Until we find the root of this bug, we circumvent it by setting the - # brand color manually and within this process making sure that all settings are really stored to the database. - And I log in as "admin" - And I navigate to "Appearance > Boost Campus" in site administration - And I click on "General settings" "link" - And I set the field "id_s_theme_boost_campus_brandcolor" to "#7a99ac" - And I press "Save changes" - And I log out @javascript @_file_upload # The setting is designed to display multiple login background images in a random order. diff --git a/tests/behat/theme_boost_campus_footer_layout_settings.feature b/tests/behat/theme_boost_campus_footer_layout_settings.feature index cecaa9ae082a7f3e08d7b626976e9fc8b972ccbb..fe32e24c6813173ac79a5e608b26f7d1bcf7e039 100644 --- a/tests/behat/theme_boost_campus_footer_layout_settings.feature +++ b/tests/behat/theme_boost_campus_footer_layout_settings.feature @@ -14,16 +14,6 @@ Feature: Configuring the theme_boost_campus plugin for the "Footer Layout Settin And the following "course enrolments" exist: | user | course | role | | teacher1 | C1 | editingteacher | - # There is a nasty bug with Behat-testing this theme that the footer is not displayed until the settings - # of the theme are stored manually. It seems not to be sufficient to just rely on the default settings being - # stored during the installation of the theme. Until we find the root of this bug, we circumvent it by setting the - # brand color manually and within this process making sure that all settings are really stored to the database. - And I log in as "admin" - And I navigate to "Appearance > Boost Campus" in site administration - And I click on "General settings" "link" - And I set the field "id_s_theme_boost_campus_brandcolor" to "#7a99ac" - And I press "Save changes" - And I log out # This scenario needs full browser support only for this Behat test to pass, otherwise javascript would not be needed. @javascript diff --git a/tests/behat/theme_boost_campus_general_settings.feature b/tests/behat/theme_boost_campus_general_settings.feature index 40b68f48bf9c5247465fb687b4d4c5354c0f6c89..0c18e8d4bfcff48e2548f113ffb43607238ae13e 100644 --- a/tests/behat/theme_boost_campus_general_settings.feature +++ b/tests/behat/theme_boost_campus_general_settings.feature @@ -4,18 +4,6 @@ Feature: Configuring the theme_boost_campus plugin for the "General settings" ta As admin I need to be able to configure the theme Boost Campus plugin - Background: - # There is a nasty bug with Behat-testing this theme that the footer is not displayed until the settings - # of the theme are stored manually. It seems not to be sufficient to just rely on the default settings being - # stored during the installation of the theme. Until we find the root of this bug, we circumvent it by setting the - # brand color manually and within this process making sure that all settings are really stored to the database. - And I log in as "admin" - And I navigate to "Appearance > Boost Campus" in site administration - And I click on "General settings" "link" - And I set the field "id_s_theme_boost_campus_brandcolor" to "#7a99ac" - And I press "Save changes" - And I log out - # This is derivated from theme Boost and should be covered there with tests # Scenario: Change "Theme preset" diff --git a/tests/behat/theme_boost_campus_info_banner_settings.feature b/tests/behat/theme_boost_campus_info_banner_settings.feature index 68f8ea4597e71b137bf03a3675cf549e49b1aba0..1a20ed411cead65800c89a45b4bdff38f01a6e5c 100644 --- a/tests/behat/theme_boost_campus_info_banner_settings.feature +++ b/tests/behat/theme_boost_campus_info_banner_settings.feature @@ -14,16 +14,6 @@ Feature: Configuring the theme_boost_campus plugin for the "Info banner Settings And the following "course enrolments" exist: | user | course | role | | teacher1 | C1 | editingteacher | - # There is a nasty bug with Behat-testing this theme that the footer is not displayed until the settings - # of the theme are stored manually. It seems not to be sufficient to just rely on the default settings being - # stored during the installation of the theme. Until we find the root of this bug, we circumvent it by setting the - # brand color manually and within this process making sure that all settings are really stored to the database. - And I log in as "admin" - And I navigate to "Appearance > Boost Campus" in site administration - And I click on "General settings" "link" - And I set the field "id_s_theme_boost_campus_brandcolor" to "#7a99ac" - And I press "Save changes" - And I log out Scenario: Display perpetual info banner on all available pages Given the following config values are set as admin: