Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
mysql-formula
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Deploy
Releases
Container registry
Model registry
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
salt
mysql-formula
Commits
26dc5628
Commit
26dc5628
authored
5 years ago
by
Imran Iqbal
Browse files
Options
Downloads
Patches
Plain Diff
ci(travis): merge `rubocop` linter into main `lint` job
* Semi-automated using
https://github.com/myii/ssf-formula/pull/65
parent
fca3b043
Branches
Branches containing commit
No related tags found
No related merge requests found
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
.travis.yml
+5
-16
5 additions, 16 deletions
.travis.yml
with
5 additions
and
16 deletions
.travis.yml
+
5
−
16
View file @
26dc5628
...
...
@@ -21,17 +21,14 @@ stages:
-
name
:
release
if
:
branch = master AND type != pull_request
jobs
:
allow_failures
:
-
env
:
Lint_rubocop
fast_finish
:
true
include
:
## Define the test stage that runs the linters (and testing matrix, if applicable)
# Run all of the linters in a single job
(except `rubocop`)
# Run all of the linters in a single job
-
language
:
node_js
node_js
:
lts/*
env
:
Lint
name
:
'
Lint:
salt-lint,
yamllint
&
commitlint'
name
:
'
Lint:
salt-lint,
yamllint
,
rubocop
&
commitlint'
before_install
:
skip
script
:
# Install and run `salt-lint`
...
...
@@ -42,21 +39,13 @@ jobs:
# Need at least `v1.17.0` for the `yaml-files` setting
-
pip install --user yamllint>=1.17.0
-
yamllint -s .
# Install and run `rubocop`
-
gem install rubocop
-
rubocop -d
# Install and run `commitlint`
-
npm install @commitlint/config-conventional -D
-
npm install @commitlint/travis-cli -D
-
commitlint-travis
# Run the `rubocop` linter in a separate job that is allowed to fail
# Once these lint errors are fixed, this can be merged into a single job
-
language
:
node_js
node_js
:
lts/*
env
:
Lint_rubocop
name
:
'
Lint:
rubocop'
before_install
:
skip
script
:
# Install and run `rubocop`
-
gem install rubocop
-
rubocop -d
## Define the rest of the matrix based on Kitchen testing
# Make sure the instances listed below match up with
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment