Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
P
pymilter-suspicious-from
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Deploy
Releases
Container registry
Model registry
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
misc
pymilter-suspicious-from
Commits
c50986cb
Commit
c50986cb
authored
5 years ago
by
Jan Philipp Timme
Browse files
Options
Downloads
Patches
Plain Diff
Restructure due to unexpected, new edgecase
parent
95af148c
Branches
Branches containing commit
No related tags found
No related merge requests found
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
main.py
+8
-4
8 additions, 4 deletions
main.py
with
8 additions
and
4 deletions
main.py
+
8
−
4
View file @
c50986cb
...
@@ -27,7 +27,7 @@ address_domain_regex = re.compile('.*@(?P<domain>[\.\w-]+)')
...
@@ -27,7 +27,7 @@ address_domain_regex = re.compile('.*@(?P<domain>[\.\w-]+)')
def
get_decoded_header
(
value
):
def
get_decoded_header
(
value
):
"""
Use python builtins to decode from header properly.
"""
"""
Use python builtins to decode
encoding stuff
from header properly.
"""
decoded_header_items
=
decode_header
(
value
)
decoded_header_items
=
decode_header
(
value
)
decoded_header_value
=
''
decoded_header_value
=
''
for
item
in
decoded_header_items
:
for
item
in
decoded_header_items
:
...
@@ -35,7 +35,7 @@ def get_decoded_header(value):
...
@@ -35,7 +35,7 @@ def get_decoded_header(value):
if
isinstance
(
decoded_item
,
bytes
):
if
isinstance
(
decoded_item
,
bytes
):
decoded_item
=
decoded_item
.
decode
(
'
ascii
'
)
decoded_item
=
decoded_item
.
decode
(
'
ascii
'
)
decoded_header_value
+=
decoded_item
decoded_header_value
+=
decoded_item
return
getaddresses
([
decoded_header_value
])[
0
]
return
decoded_header_value
def
normalizeRawFromHeader
(
value
):
def
normalizeRawFromHeader
(
value
):
...
@@ -69,10 +69,14 @@ class SuspiciousFrom(Milter.Base):
...
@@ -69,10 +69,14 @@ class SuspiciousFrom(Milter.Base):
if
value
==
''
:
if
value
==
''
:
logger
.
warn
(
f
"
Got empty from header value! WTF! Skipping.
"
)
logger
.
warn
(
f
"
Got empty from header value! WTF! Skipping.
"
)
return
Milter
.
CONTINUE
return
Milter
.
CONTINUE
data
=
get_decoded_header
(
value
)
decoded_from
=
get_decoded_header
(
value
)
logger
.
debug
(
f
"
(
{
self
.
id
}
) Decoded from as a whole:
'
{
decoded_from
}
'"
)
data
=
getaddresses
([
decoded_from
])[
0
]
logger
.
info
(
f
"
(
{
self
.
id
}
) Label:
'
{
data
[
0
]
}
'
, Address:
'
{
data
[
1
]
}
'"
)
logger
.
info
(
f
"
(
{
self
.
id
}
) Label:
'
{
data
[
0
]
}
'
, Address:
'
{
data
[
1
]
}
'"
)
if
data
[
0
]
==
''
:
if
data
[
0
]
==
''
:
logger
.
info
(
f
"
(
{
self
.
id
}
) No label in from header, OK!
"
)
logger
.
info
(
f
"
(
{
self
.
id
}
) No label in from header, should be OK!
"
)
if
decoded_from
.
count
(
'
@
'
)
>
1
:
logger
.
info
(
f
"
(
{
self
.
id
}
) Raw decoded from header contains multiple
'
@
'
-charecters - investigating!
"
)
self
.
new_headers
.
append
({
'
name
'
:
'
X-From-Checked
'
,
'
value
'
:
'
OK - No label specified
'
})
self
.
new_headers
.
append
({
'
name
'
:
'
X-From-Checked
'
,
'
value
'
:
'
OK - No label specified
'
})
self
.
new_headers
.
append
({
'
name
'
:
'
X-From-Suspicious
'
,
'
value
'
:
'
NO
'
})
self
.
new_headers
.
append
({
'
name
'
:
'
X-From-Suspicious
'
,
'
value
'
:
'
NO
'
})
else
:
else
:
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment