JI-1010 Add help message if iframe embedding is disabled on site

Disable download button for mobile view, since it does not work
Add white background when viewing the H5P, makes resizing look better

classes/output/mobile.php

@@ -27,6 +27,23 @@ class mobile {
         global $DB, $CFG, $OUTPUT, $USER;
 
         $cmid = $args['cmid'];
+        if (!$CFG->allowframembedding) {
+            $context = \context_system::instance();
+            if (has_capability('moodle/site:config', $context)) {
+                $template = 'mod_hvp/iframe_embedding_disabled';
+            }
+            else {
+                $template = 'mod_hvp/contact_site_administrator';
+            }
+            return array(
+                'templates' => array(
+                    array(
+                        'id' => 'noiframeembedding',
+                        'html' => $OUTPUT->render_from_template($template, [])
+                    )
+                )
+            );
+        }
 
         // Verify course context.
         $cm = get_coursemodule_from_id('hvp', $cmid);

classes/view_assets.php

@@ -45,7 +45,7 @@ class view_assets {
     protected $embedtype;
     protected $files;
 
-    public function __construct($cm, $course, $forceembedtype = null) {
+    public function __construct($cm, $course, $options = []) {
         global $CFG;
 
         $this->cm          = $cm;
@@ -58,6 +58,9 @@ class view_assets {
 
         $context        = \context_module::instance($this->cm->id);
         $displayoptions = $this->core->getDisplayOptionsForView($this->content['disable'], $context->instanceid);
+        if (isset($options['disabledownload']) && $options['disabledownload']) {
+            $displayoptions[\H5PCore::DISPLAY_OPTION_DOWNLOAD] = false;
+        }
 
         // Add JavaScript settings for this content.
         $cid                                  = 'cid-' . $this->content['id'];
@@ -78,7 +81,7 @@ class view_assets {
             )
         );
 
-        $this->embedtype = isset($forceembedtype) ? $forceembedtype : \H5PCore::determineEmbedType(
+        $this->embedtype = isset($options->forceembedtype) ? $options->forceembedtype : \H5PCore::determineEmbedType(
             $this->content['embedType'], $this->content['library']['embedTypes']
         );
 

embed.php

@@ -30,9 +30,11 @@ $id = required_param('id', PARAM_INT);
 // Allow login through an authentication token.
 $userid = optional_param('user_id', null, PARAM_ALPHANUMEXT);
 $secret  = optional_param('secret', null, PARAM_RAW);
+$disabledownload = false;
 if (\mod_hvp\mobile_auth::has_valid_token($userid, $secret)) {
     $user = get_complete_user_data('id', $userid);
     complete_user_login($user);
+    $disabledownload = true;
 }
 
 // Verify course context.
@@ -67,7 +69,7 @@ $context = context_module::instance($cm->id);
 require_capability('mod/hvp:view', $context);
 
 // Set up view assets.
-$view    = new \mod_hvp\view_assets($cm, $course);
+$view    = new \mod_hvp\view_assets($cm, $course, ['disabledownload' => $disabledownload]);
 $content = $view->getcontent();
 $view->validatecontent();
 

templates/contact_site_administrator.mustache

+<div style="padding: 1em;">This site is not configured properly for displaying mobile H5P content. Please contact a site administrator.</div>
\ No newline at end of file

templates/iframe_embedding_disabled.mustache

+<div style="padding: 1em">
+    <div>Iframe embedding must be enabled in order to display H5P content in the mobile app.</div>
+    <div>You can enable it by checking "Allow frame embedding" in <a href="/admin/settings.php?section=httpsecurity" core-link>Site Administration / Security / Http Security</a></div>
+</div>
\ No newline at end of file

templates/mobile_view_page.mustache

 {{=<% %>=}}
+<div style="height: 100%; width: 100%; background: white;">
     <iframe
             src="<% wwwroot %>/mod/hvp/embed.php?id=<% cmid %>&user_id=<% user_id %>&secret=<% secret %>"
             frameborder="0"
             allowfullscreen="allowfullscreen">
     </iframe>
+</div>