-
- Downloads
feat(patches): add first community patches
Because the H5P plugin team seems to be very slow, we should adopt a few fixes/changes the community has implemented (and ideally even battle- tested). I devised the following concept based on a workflow I have seen in other repositories (e.g. ´https://github.com/Frogging-Family/linux-tkg´). We add pull requests or other fixes/changes as a single-patch file to a folder (here: ´./patches´). This way, we can track what each changes each fix needs, and are able to revert them easily, in case the official H5P repo contains a fix in the future for one of the issues. Because we could pull these changes from many different places, I would suggest we use the following scheme for persistence: ´ ./patches/gitProviderURL/gitUserOrOrganisationName/gitRepoName/pullRequestID-description.patch ´ So, for example, if we want to merge a patch from GitHub, from the user ´catalyst´ and the repo name ´moodle-mod_hvp´, it would look like this: ´ ./patches/github.com/catalyst/moodle-mod_hvp/001-example-filename.patch ´ This way, we can easily track where we got the patches from without the need to keep a list around. This allows us also to check the pull requests in future for discussions, i.e. are they still needed? did another user find a better way to fix it? is the pull request merged or did the H5P team reject it for some reason? Our own patches should go either into the base ´./patches´ folder, or if wished for, we create a ´HsH´ subfolder. This commit contains two of these patches: * Pull request #425: A fix for allowing H5P content in the mobile app without the need to allow frame embeddings globally * Pull request #458: A fix for an ongoing resizing issue with embedded videos. This one seems to only fix embedded videos, sadly, as we are still plagued from other resizing issues. Both fixes are pretty important IMHO to increase the h5p adoption of both user groups (students, teachers).
Showing
- patches/github.com/h5p/moodle-mod_hvp/425-match-handling-of-allowframeembedding-for-mobile-app-like-moodle-core.patch 23 additions, 0 deletions...allowframeembedding-for-mobile-app-like-moodle-core.patch
- patches/github.com/h5p/moodle-mod_hvp/458-fix-for-embedded-video-resizing-problem.patch 206 additions, 0 deletions...mod_hvp/458-fix-for-embedded-video-resizing-problem.patch
This diff is collapsed.
Please register or sign in to comment