Skip to content
Snippets Groups Projects
Commit 9f383772 authored by Justus Dieckmann's avatar Justus Dieckmann
Browse files

Workflow backup: Do not save attributes when they are null

parent 1c048dc2
No related branches found
No related tags found
No related merge requests found
...@@ -107,9 +107,11 @@ class backup_lifecycle_workflow { ...@@ -107,9 +107,11 @@ class backup_lifecycle_workflow {
*/ */
private function write_workflow() { private function write_workflow() {
foreach (get_object_vars($this->workflow) as $prop => $value) { foreach (get_object_vars($this->workflow) as $prop => $value) {
if (!is_null($value)) {
$this->writer->writeAttribute($prop, $value); $this->writer->writeAttribute($prop, $value);
} }
} }
}
/** /**
* Write all trigger of the workflow with all their attributes to the xmlwriter. * Write all trigger of the workflow with all their attributes to the xmlwriter.
...@@ -118,13 +120,17 @@ class backup_lifecycle_workflow { ...@@ -118,13 +120,17 @@ class backup_lifecycle_workflow {
foreach ($this->trigger as $trigger) { foreach ($this->trigger as $trigger) {
$this->writer->startElement("trigger"); $this->writer->startElement("trigger");
foreach (get_object_vars($trigger) as $prop => $value) { foreach (get_object_vars($trigger) as $prop => $value) {
if (!is_null($value)) {
$this->writer->writeAttribute($prop, $value); $this->writer->writeAttribute($prop, $value);
} }
}
$settings = settings_manager::get_settings($trigger->id, settings_type::TRIGGER); $settings = settings_manager::get_settings($trigger->id, settings_type::TRIGGER);
foreach ($settings as $name => $value) { foreach ($settings as $name => $value) {
$this->writer->startElement("setting"); $this->writer->startElement("setting");
$this->writer->writeAttribute('name', $name); $this->writer->writeAttribute('name', $name);
if (!is_null($value)) {
$this->writer->writeAttribute('value', $value); $this->writer->writeAttribute('value', $value);
}
$this->writer->endElement(); $this->writer->endElement();
} }
$this->writer->endElement(); $this->writer->endElement();
...@@ -139,13 +145,17 @@ class backup_lifecycle_workflow { ...@@ -139,13 +145,17 @@ class backup_lifecycle_workflow {
foreach ($this->steps as $step) { foreach ($this->steps as $step) {
$this->writer->startElement("step"); $this->writer->startElement("step");
foreach (get_object_vars($step) as $prop => $value) { foreach (get_object_vars($step) as $prop => $value) {
if (!is_null($value)) {
$this->writer->writeAttribute($prop, $value); $this->writer->writeAttribute($prop, $value);
} }
}
$settings = settings_manager::get_settings($step->id, settings_type::STEP); $settings = settings_manager::get_settings($step->id, settings_type::STEP);
foreach ($settings as $name => $value) { foreach ($settings as $name => $value) {
$this->writer->startElement("setting"); $this->writer->startElement("setting");
$this->writer->writeAttribute('name', $name); $this->writer->writeAttribute('name', $name);
if (!is_null($value)) {
$this->writer->writeAttribute('value', $value); $this->writer->writeAttribute('value', $value);
}
$this->writer->endElement(); $this->writer->endElement();
} }
$this->writer->endElement(); $this->writer->endElement();
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment