Save new properties to workflow when edited

adminlib.php

@@ -283,6 +283,9 @@ class admin_settings {
                 $workflow = workflow_manager::get_workflow($data->id);
                 $workflow->title = $data->title;
                 $workflow->displaytitle = $data->displaytitle;
+                $workflow->rollbackdelay = $data->rollbackdelay;
+                $workflow->finishdelay = $data->finishdelay;
+                $workflow->delayforallworkflows = property_exists($data, 'delayforallworkflows') ? $data->delayforallworkflows : 0;
                 $newworkflow = false;
             } else {
                 $workflow = workflow::from_record($data);

classes/manager/delayed_courses_manager.php

@@ -29,9 +29,8 @@ defined('MOODLE_INTERNAL') || die();
 
 class delayed_courses_manager {
 
-    public static function set_course_delayed_for_workflow($courseid, $becauserollback, $workfloworid = null) {
-        global $DB, $CFG;
-        if ($workfloworid) {
+    public static function set_course_delayed_for_workflow($courseid, $becauserollback, $workfloworid) {
+        global $DB;
         if (is_object($workfloworid)) {
             $workflow = $workfloworid;
         } else {
@@ -46,7 +45,8 @@ class delayed_courses_manager {
             self::set_course_delayed($courseid, $duration);
         } else {
             $delayeduntil = time() + $duration;
-                $record = $DB->get_record('tool_lifecycle_delayed_workf', array('courseid' => $courseid, 'workflowid' => $workflow->id));
+            $record = $DB->get_record('tool_lifecycle_delayed_workf',
+                        array('courseid' => $courseid, 'workflowid' => $workflow->id));
             if (!$record) {
                 $record = new \stdClass();
                 $record->courseid = $courseid;
@@ -60,9 +60,7 @@ class delayed_courses_manager {
                 }
             }
         }
-        } else {
-            self::set_course_delayed($courseid, $CFG->lifecycle_duration);
-        }
+
     }
 
     public static function get_delayed_courses_for_workflow($workflowid) {