Skip to content
Snippets Groups Projects
Commit 373b51b2 authored by Chris Sangwin's avatar Chris Sangwin
Browse files

Improve layout of answer test results.

parent e5ae7076
No related branches found
No related tags found
No related merge requests found
...@@ -51,8 +51,6 @@ foreach ($availabletests as $anstest) { ...@@ -51,8 +51,6 @@ foreach ($availabletests as $anstest) {
'teacheranswer' => stack_string('teacheranswer'), 'teacheranswer' => stack_string('teacheranswer'),
'options' => stack_string('options_short'), 'options' => stack_string('options_short'),
'rawmark' => stack_string('testsuitecolmark'), 'rawmark' => stack_string('testsuitecolmark'),
'error' => stack_string('testsuitecolerror'),
'feedback' => stack_string('testsuitefeedback'),
'answernote' => stack_string('answernote'), 'answernote' => stack_string('answernote'),
); );
...@@ -85,7 +83,7 @@ foreach ($availabletests as $anstest) { ...@@ -85,7 +83,7 @@ foreach ($availabletests as $anstest) {
reset($columns); reset($columns);
$firstcol = key($columns); $firstcol = key($columns);
// This is a slight cludge to get multiple columns in a row. // This is a slight cludge to get multiple columns in a row.
$notes = html_writer::tag('td', $test->notes, array('colspan' => '8')); $notes = html_writer::tag('td', $test->notes, array('colspan' => '6'));
$table->add_data(array($notes), 'notes'); $table->add_data(array($notes), 'notes');
} }
...@@ -130,9 +128,6 @@ foreach ($availabletests as $anstest) { ...@@ -130,9 +128,6 @@ foreach ($availabletests as $anstest) {
'teacheranswer' => html_writer::tag('pre', $tans), 'teacheranswer' => html_writer::tag('pre', $tans),
'options' => $topt, 'options' => $topt,
'rawmark' => $mark, 'rawmark' => $mark,
'error' => $error,
'feedback' => format_text($feedback),
'feedback' => $feedback,
'answernote' => $ansnote, 'answernote' => $ansnote,
); );
if (!$passed) { if (!$passed) {
...@@ -141,6 +136,21 @@ foreach ($availabletests as $anstest) { ...@@ -141,6 +136,21 @@ foreach ($availabletests as $anstest) {
} }
$table->add_data_keyed($row, $class); $table->add_data_keyed($row, $class);
// Add errors as a separate row for better spacing.
$row = [];
$row[] = html_writer::tag('td', '', array('colspan' => '2'));
$row[] = html_writer::tag('td', $error, array('colspan' => '4'));
if ($error != '') {
$table->add_data($row, $class);
}
// Add feeback as a separate row for better spacing.
$row = [];
$row[] = html_writer::tag('td', '', array('colspan' => '2'));
$row[] = html_writer::tag('td', $feedback, array('colspan' => '4'));
if ($feedback != '' && $feedback != $error) {
$table->add_data($row, $class);
}
} }
$table->finish_output(); $table->finish_output();
......
This diff is collapsed.
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment