Code tidy, and ignore 3rd party libraries on code checker.

bulktestall.php

@@ -48,6 +48,8 @@ $PAGE->set_context($context);
 $title = stack_string('bulktesttitle', $context->get_context_name());
 $PAGE->set_title($title);
 
+require_login();
+
 // Create the helper class.
 $bulktester = new stack_bulk_tester();
 $allpassed = true;

bulktestindex.php

@@ -40,6 +40,8 @@ $PAGE->set_url('/question/type/stack/bulktestindex.php');
 $PAGE->set_context($context);
 $PAGE->set_title(stack_string('bulktestindextitle'));
 
+require_login();
+
 // Create the helper class.
 $bulktester = new stack_bulk_tester();
 

deploy.php

@@ -46,6 +46,8 @@ $PAGE->set_url($nexturl); // Since this script always ends in a redirect.
 $PAGE->set_heading($COURSE->fullname);
 $PAGE->set_pagelayout('admin');
 
+require_login();
+
 // Process deploy if applicable.
 $deploy = optional_param('deploy', null, PARAM_INT);
 if (!is_null($deploy)) {

equivdemo.php

@@ -61,6 +61,8 @@ $PAGE->set_url('/question/type/stack/equivdemo.php', $urlparams);
 $title = "Equivalence reasoning test cases";
 $PAGE->set_title($title);
 
+require_login();
+
 echo $OUTPUT->header();
 echo $OUTPUT->heading($title);
 

exportone.php

@@ -50,6 +50,8 @@ $PAGE->set_url($nexturl); // Since this script always ends in a redirect.
 $PAGE->set_heading($COURSE->fullname);
 $PAGE->set_pagelayout('admin');
 
+require_login();
+
 // Set up the export format.
 $qformat = new qformat_xml();
 $filename = question_default_export_filename($COURSE, $questiondata) .

lang/en/qtype_stack.php

@@ -702,6 +702,7 @@ $string['stackOptions_AnsTest_values_NumRelative']         = "NumRelative";
 $string['stackOptions_AnsTest_values_NumAbsolute']         = "NumAbsolute";
 $string['stackOptions_AnsTest_values_NumSigFigs']          = "NumSigFigs";
 $string['stackOptions_AnsTest_values_NumDecPlaces']        = "NumDecPlaces";
+$string['stackOptions_AnsTest_values_NumDecPlacesWrong']   = "NumDecPlacesWrong";
 $string['stackOptions_AnsTest_values_UnitsSigFigs']        = "UnitsSigFigs";
 $string['stackOptions_AnsTest_values_UnitsStrictSigFigs']  = "UnitsStrictSigFigs";
 $string['stackOptions_AnsTest_values_UnitsRelative']       = "UnitsRelative";

questiontestdelete.php

@@ -52,6 +52,8 @@ $PAGE->set_url('/question/type/stack/questiontestdelete.php', $urlparams);
 $title = stack_string('deletetestcase',
         array('no' => $testcase, 'question' => format_string($question->name)));
 
+require_login();
+
 if (data_submitted() && confirm_sesskey()) {
     // User has confirmed. Actually delete the test case.
     question_bank::get_qtype('stack')->delete_question_test($questionid, $testcase);

questiontestedit.php

@@ -65,6 +65,9 @@ $PAGE->set_url('/question/type/stack/questiontestedit.php', $urlparams);
 $PAGE->set_title($title);
 $PAGE->set_heading($title);
 $PAGE->set_pagelayout('popup');
+
+require_login();
+
 // Create the question usage we will use.
 $quba = question_engine::make_questions_usage_by_activity('qtype_stack', $context);
 $quba->set_preferred_behaviour('adaptive');

questiontestrun.php

@@ -62,6 +62,8 @@ $PAGE->set_title($title);
 $PAGE->set_heading($title);
 $PAGE->set_pagelayout('popup');
 
+require_login();
+
 // Create some other useful links.
 $qbankparams = $urlparams;
 unset($qbankparams['questionid']);

stack/bulktester.class.php

@@ -19,6 +19,8 @@
 // @copyright  2015 The Open University.
 // @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later.
 
+defined('MOODLE_INTERNAL') || die();
+
 class stack_bulk_tester  {
 
     /**

stack/cas/installhelper.class.php

@@ -16,9 +16,7 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-// The file provides helper code for creating the files needed to connect to the CAS.
-
-require_once(__DIR__.'/../../../../../config.php');
+// This provides helper code for creating the files needed to connect to the CAS.
 
 require_once(__DIR__ . '/../../locallib.php');
 require_once(__DIR__ . '/../utils.class.php');

tests/behat/behat_qtype_stack.php

@@ -46,7 +46,7 @@ class behat_qtype_stack extends behat_base {
      *
      * @When /^I set up STACK using the PHPUnit configuration$/
      */
-    public function iSetUpStackUsingThePhpunitConfiguration() {
+    public function isetupstackusingthephpunitconfiguration() {
         // The require_once is here, this file may be required by behat before including /config.php.
         require_once(__DIR__ . '/../fixtures/test_maxima_configuration.php');
 

tests/input_textarea_test.php

@@ -179,6 +179,7 @@ class stack_textarea_input_test extends qtype_stack_testcase {
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class testable_stack_textarea_input extends stack_textarea_input {
+    // @codingStandardsIgnoreLine
     public function tokenize_list($in) {
         return parent::tokenize_list($in);
     }

tests/multilang_test.php

@@ -21,8 +21,8 @@ require_once(__DIR__ . '/../lang/multilang.php');
 
 // Unit tests for stack_multilang.
 //
-// @copyright  2018 The University of Edinburgh
-// @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+// @copyright  2018 The University of Edinburgh.
+// @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later.
 
 /**
  * @group qtype_stack

tests/parser_test.php

@@ -14,6 +14,8 @@
 // You should have received a copy of the GNU General Public License
 // along with Stack.  If not, see <http://www.gnu.org/licenses/>.
 
+defined('MOODLE_INTERNAL') || die();
+
 require_once(__DIR__ . '/../locallib.php');
 require_once(__DIR__ . '/fixtures/test_base.php');
 require_once(__DIR__ . '/../stack/cas/castext/castextparser.class.php');

tests/restore_logic_test.php

@@ -65,6 +65,7 @@ class testable_restore_qtype_stack_plugin extends restore_qtype_stack_plugin {
         return $this->log;
     }
 
+    // @codingStandardsIgnoreLine
     public function after_execute_question() {
         // Make method public.
         parent::after_execute_question();

thirdpartylibs.xml

+<?xml version="1.0"?>
+<libraries>
+    <library>
+        <location>amd</location>
+        <name>JSXGraph</name>
+        <version>?</version>
+        <license>GNU LGPL or MIT License</license>
+    </library>
+    <library>
+        <location>thirdparty/php-peg</location>
+        <name>PHP-PEG</name>
+        <version>2.0.0</version>
+        <license>MIT, BSD, and GPL</license>
+    </library>
+    <library>
+        <location>stack/cas/castext/</location>
+        <name>PHP-PEG autogenerated PHP files</name>
+        <version>As for STACK</version>
+        <license>GPL</license>
+    </library>
+</libraries>
+
+
+
+

tidyquestion.php

@@ -49,6 +49,8 @@ $PAGE->set_title($title);
 $PAGE->set_heading($COURSE->fullname);
 $PAGE->set_pagelayout('admin');
 
+require_login();
+
 // The URL back to the preview page.
 $returnurl = question_preview_url($questionid, null, null, null, null, $context);