Skip to content
Snippets Groups Projects
Commit e008b226 authored by Alexander Bias's avatar Alexander Bias
Browse files

Make codechecker happier

parent b0aa16f3
No related branches found
No related tags found
No related merge requests found
...@@ -295,9 +295,6 @@ class block_course_overview_campus extends block_base { ...@@ -295,9 +295,6 @@ class block_course_overview_campus extends block_base {
$courseterm->id = ($coursestartyear - 1).'-'.$coursestartyear; $courseterm->id = ($coursestartyear - 1).'-'.$coursestartyear;
$courseterm->name = block_course_overview_campus_get_term_displayname($coc_config->term1name, ($coursestartyear - 1), $coursestartyear); $courseterm->name = block_course_overview_campus_get_term_displayname($coc_config->term1name, ($coursestartyear - 1), $coursestartyear);
} }
// Discard date information.
unset($courseyday, $courseyear, $term1startday);
} }
// "Semester" mode. // "Semester" mode.
else if ($coc_config->termmode == 2) { else if ($coc_config->termmode == 2) {
...@@ -331,9 +328,6 @@ class block_course_overview_campus extends block_base { ...@@ -331,9 +328,6 @@ class block_course_overview_campus extends block_base {
$courseterm->name = block_course_overview_campus_get_term_displayname($coc_config->term2name, $coursestartyear, ($coursestartyear + 1)); $courseterm->name = block_course_overview_campus_get_term_displayname($coc_config->term2name, $coursestartyear, ($coursestartyear + 1));
} }
} }
// Discard date information.
unset($courseyday, $courseyear, $term1startday, $term2startday);
} }
// "Tertial" mode. // "Tertial" mode.
else if ($coc_config->termmode == 3) { else if ($coc_config->termmode == 3) {
...@@ -374,9 +368,6 @@ class block_course_overview_campus extends block_base { ...@@ -374,9 +368,6 @@ class block_course_overview_campus extends block_base {
$courseterm->name = block_course_overview_campus_get_term_displayname($coc_config->term3name, $coursestartyear, ($coursestartyear + 1)); $courseterm->name = block_course_overview_campus_get_term_displayname($coc_config->term3name, $coursestartyear, ($coursestartyear + 1));
} }
} }
// Discard date information.
unset($courseyday, $courseyear, $term1startday, $term2startday, $term3startday);
} }
// "Trimester" mode. // "Trimester" mode.
else if ($coc_config->termmode == 4) { else if ($coc_config->termmode == 4) {
...@@ -424,9 +415,6 @@ class block_course_overview_campus extends block_base { ...@@ -424,9 +415,6 @@ class block_course_overview_campus extends block_base {
$courseterm->name = block_course_overview_campus_get_term_displayname($coc_config->term4name, $coursestartyear, ($coursestartyear + 1)); $courseterm->name = block_course_overview_campus_get_term_displayname($coc_config->term4name, $coursestartyear, ($coursestartyear + 1));
} }
} }
// Discard date information.
unset($courseyday, $courseyear, $term1startday, $term2startday, $term3startday, $term4startday);
} }
// This should never happen. // This should never happen.
else { else {
......
...@@ -53,6 +53,7 @@ function block_course_overview_campus_course_hidden_by_hidecourses($course) { ...@@ -53,6 +53,7 @@ function block_course_overview_campus_course_hidden_by_hidecourses($course) {
// Course is visible if it isn't hidden. // Course is visible if it isn't hidden.
if (get_user_preferences('block_course_overview_campus-hidecourse-'.$course->id, 0) == 0) { if (get_user_preferences('block_course_overview_campus-hidecourse-'.$course->id, 0) == 0) {
return false; return false;
// Otherwise it is hidden. // Otherwise it is hidden.
} else { } else {
return true; return true;
...@@ -71,6 +72,7 @@ function block_course_overview_campus_coursenews_hidden($course) { ...@@ -71,6 +72,7 @@ function block_course_overview_campus_coursenews_hidden($course) {
if (get_user_preferences('block_course_overview_campus-hidenews-'.$course->id, if (get_user_preferences('block_course_overview_campus-hidenews-'.$course->id,
get_config('block_course_overview_campus', 'coursenewsdefault')) == 1) { get_config('block_course_overview_campus', 'coursenewsdefault')) == 1) {
return true; return true;
// Otherwise it is visible. // Otherwise it is visible.
} else { } else {
return false; return false;
...@@ -89,6 +91,7 @@ function block_course_overview_campus_course_hidden_by_termcoursefilter($course, ...@@ -89,6 +91,7 @@ function block_course_overview_campus_course_hidden_by_termcoursefilter($course,
// Course is visible if it is within selected term or all terms are selected. // Course is visible if it is within selected term or all terms are selected.
if ($course->term == $selectedterm || $selectedterm == 'all') { if ($course->term == $selectedterm || $selectedterm == 'all') {
return false; return false;
// Otherwise it is hidden. // Otherwise it is hidden.
} else { } else {
return true; return true;
...@@ -107,6 +110,7 @@ function block_course_overview_campus_course_hidden_by_categorycoursefilter($cou ...@@ -107,6 +110,7 @@ function block_course_overview_campus_course_hidden_by_categorycoursefilter($cou
// Course is visible if it is within selected parent category or all categories are selected. // Course is visible if it is within selected parent category or all categories are selected.
if ($course->categoryid == $selectedcategory || $selectedcategory == 'all') { if ($course->categoryid == $selectedcategory || $selectedcategory == 'all') {
return false; return false;
// Otherwise it is hidden. // Otherwise it is hidden.
} else { } else {
return true; return true;
...@@ -125,6 +129,7 @@ function block_course_overview_campus_course_hidden_by_toplevelcategorycoursefil ...@@ -125,6 +129,7 @@ function block_course_overview_campus_course_hidden_by_toplevelcategorycoursefil
// Course is visible if it is within selected top level category or all categories are selected. // Course is visible if it is within selected top level category or all categories are selected.
if ($course->toplevelcategoryid == $selectedtoplevelcategory || $selectedtoplevelcategory == 'all') { if ($course->toplevelcategoryid == $selectedtoplevelcategory || $selectedtoplevelcategory == 'all') {
return false; return false;
// Otherwise it is hidden. // Otherwise it is hidden.
} else { } else {
return true; return true;
...@@ -143,6 +148,7 @@ function block_course_overview_campus_course_hidden_by_teachercoursefilter($cour ...@@ -143,6 +148,7 @@ function block_course_overview_campus_course_hidden_by_teachercoursefilter($cour
// Course is visible if it has the selected teacher or all teachers are selected. // Course is visible if it has the selected teacher or all teachers are selected.
if (isset($course->teachers[$selectedteacher]) || $selectedteacher == 'all') { if (isset($course->teachers[$selectedteacher]) || $selectedteacher == 'all') {
return false; return false;
// Otherwise it is hidden. // Otherwise it is hidden.
} else { } else {
return true; return true;
......
...@@ -45,7 +45,7 @@ ...@@ -45,7 +45,7 @@
#coc-courselist .coc-metainfo { #coc-courselist .coc-metainfo {
font-size: 85%; font-size: 85%;
font-weight: normal !important; /* To prevent the text from being shown in bold as it's still a h3 heading*/ font-weight: normal; /* To prevent the text from being shown in bold as it's still a h3 heading*/
white-space: pre-wrap; /* To support multiple whitespaces before and after pipe */ white-space: pre-wrap; /* To support multiple whitespaces before and after pipe */
} }
......
...@@ -6,7 +6,6 @@ ...@@ -6,7 +6,6 @@
} }
/* Below are styles which are needed because Boost (BS 4) makes things different from Bootstrapbase (BS 2) */ /* Below are styles which are needed because Boost (BS 4) makes things different from Bootstrapbase (BS 2) */
.path-my .block_course_overview_campus .coursebox { .path-my .block_course_overview_campus .coursebox {
......
...@@ -6,7 +6,6 @@ ...@@ -6,7 +6,6 @@
} }
/* Below are styles which are needed because Boost (BS 4) makes things different from Bootstrapbase (BS 2) */ /* Below are styles which are needed because Boost (BS 4) makes things different from Bootstrapbase (BS 2) */
.block_course_overview_campus .row { .block_course_overview_campus .row {
margin-left: 0; margin-left: 0;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment