From e96dc96a5b7230cf58e8e94ba0929de20a96a05d Mon Sep 17 00:00:00 2001
From: Thomas Marstrander <marstranderthomas@gmail.com>
Date: Wed, 13 Mar 2019 17:23:23 +0100
Subject: [PATCH] Fix not using LIMIT to support dbs where it is not valid
syntax
---
classes/framework.php | 23 +++++++++++++----------
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/classes/framework.php b/classes/framework.php
index f0e6b30..1dab43d 100644
--- a/classes/framework.php
+++ b/classes/framework.php
@@ -1597,19 +1597,22 @@ class framework implements \H5PFrameworkInterface {
public function libraryHasUpgrade($library) {
global $DB;
- return !!$DB->get_field_sql(
- "SELECT id
+ $results = $DB->get_records_sql(
+ "SELECT id
FROM {hvp_libraries}
WHERE machine_name = ?
AND (major_version > ?
- OR (major_version = ? AND minor_version > ?))
- LIMIT 1",
- array(
- $library['machineName'],
- $library['majorVersion'],
- $library['majorVersion'],
- $library['minorVersion']
- )
+ OR (major_version = ? AND minor_version > ?))",
+ array(
+ $library['machineName'],
+ $library['majorVersion'],
+ $library['majorVersion'],
+ $library['minorVersion']
+ ),
+ 0,
+ 1
);
+
+ return !empty($results);
}
}
--
GitLab