From 6530fff561ebc3205727a47c61c95e7868b38808 Mon Sep 17 00:00:00 2001 From: Tobias Reischmann <tobias.reischmann@wi.uni-muenster.de> Date: Wed, 28 Aug 2019 13:06:32 +0200 Subject: [PATCH] Fix two handlings of displaytitle for workflows --- classes/manager/workflow_manager.php | 2 +- tests/generator/lib.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/classes/manager/workflow_manager.php b/classes/manager/workflow_manager.php index 32c53f7..4fe33ed 100644 --- a/classes/manager/workflow_manager.php +++ b/classes/manager/workflow_manager.php @@ -364,7 +364,7 @@ class workflow_manager { public static function create_workflow($title, $displaytitle = null) { $record = new \stdClass(); $record->title = $title; - if ($displaytitle) { + if (!is_null($displaytitle)) { $record->displaytitle = $displaytitle; } $workflow = workflow::from_record($record); diff --git a/tests/generator/lib.php b/tests/generator/lib.php index 9256452..408733a 100644 --- a/tests/generator/lib.php +++ b/tests/generator/lib.php @@ -74,7 +74,7 @@ class tool_lifecycle_generator extends testing_module_generator { $record = new stdClass(); $record->id = null; $record->title = 'myworkflow'; - $record->title = 'random displaystring:' . random_string(10); + $record->displaytitle = 'random displaystring:' . random_string(10); $workflow = workflow::from_record($record); workflow_manager::insert_or_update($workflow); foreach ($stepnames as $subpluginname) { -- GitLab