From bb9f99d1da64465a21c420aec23fdc7d0e89ba86 Mon Sep 17 00:00:00 2001
From: Art Lukyanchyk <artiom.lukyanchyk@hs-hannover.de>
Date: Sun, 29 Aug 2021 21:00:42 +0200
Subject: [PATCH] Insignificant details

---
 ssoauth/app_settings/__init__.py | 11 +++++------
 ssoauth/app_settings/defaults.py |  7 ++-----
 2 files changed, 7 insertions(+), 11 deletions(-)

diff --git a/ssoauth/app_settings/__init__.py b/ssoauth/app_settings/__init__.py
index f6c7bdc..7381b96 100644
--- a/ssoauth/app_settings/__init__.py
+++ b/ssoauth/app_settings/__init__.py
@@ -9,12 +9,11 @@ from .defaults import *
 # merge defaults with customized user settings
 
 for setting_name in [k for k in globals().keys() if k.isupper()]:
-        for name in ["SSOAUTH_" + setting_name, setting_name]:
-            try:
-                globals()[setting_name] = getattr(conf.settings, name)
-                continue
-            except (KeyError, AttributeError):
-                pass  # not set
+    for name in [setting_name, "SSOAUTH_" + setting_name]:
+        try:
+            globals()[setting_name] = getattr(conf.settings, name)
+        except (KeyError, AttributeError):
+            pass  # not set
 
 
 # template for OneLogin toolkit settings
diff --git a/ssoauth/app_settings/defaults.py b/ssoauth/app_settings/defaults.py
index 733a7d9..e8e98d8 100644
--- a/ssoauth/app_settings/defaults.py
+++ b/ssoauth/app_settings/defaults.py
@@ -3,12 +3,9 @@ from django.conf import settings as django_settings
 
 
 """
-Changing settings in Django:
-  - put the setting it into your project settings
+Changing settings:
+  - put the setting it into your django project settings
   - optionally prefix the setting with "SSOAUTH_"
-Changing settings outside of Django:
-  - import ssoauth.app_settings
-  - ssoauth.app_settings.SETTING_NAME = "your new value"
 """
 
 
-- 
GitLab