From 626ad71e39dcb28309790a9d92f905c96e7ead1f Mon Sep 17 00:00:00 2001
From: Art Lukyanchyk <artiom.lukyanchyk@hs-hannover.de>
Date: Thu, 1 Feb 2024 19:05:35 +0100
Subject: [PATCH] Fix highlighting of error-ed fields in bulma forms
---
hshassets/forms/utils.py | 3 ++-
hshassets/templatetags/bulma.py | 5 -----
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/hshassets/forms/utils.py b/hshassets/forms/utils.py
index daa637c0..af195b94 100644
--- a/hshassets/forms/utils.py
+++ b/hshassets/forms/utils.py
@@ -107,7 +107,8 @@ class BulmaFieldMarkup(object):
css_classes = 'select is-multiple'
else:
css_classes = 'select'
-
+ if field.errors:
+ css_classes += " is-danger"
return cls.label(field.label, cls.div_control(format_html('<div class="{}">{}</div>', css_classes, content)))
@classmethod
diff --git a/hshassets/templatetags/bulma.py b/hshassets/templatetags/bulma.py
index 0d2d35bf..6e831d71 100644
--- a/hshassets/templatetags/bulma.py
+++ b/hshassets/templatetags/bulma.py
@@ -26,11 +26,6 @@ def bulma_form_fields(form):
elif isinstance(field.field.widget, widgets.Textarea):
widget_classes.append("textarea")
- # highlight fields with errors
- if field.errors:
- widget_classes.append("is-danger")
-
- # done
if field.field.widget.attrs.get('class'):
widget_classes.append(field.field.widget.attrs['class'])
--
GitLab