From 2ee08799c288f58d7db8ca6baf29dad7fdd621d0 Mon Sep 17 00:00:00 2001
From: beckerfy <fynn.becker@hs-hannover.de>
Date: Thu, 20 Aug 2020 13:58:36 +0200
Subject: [PATCH] Improve type hinting for the BreadCrumbMixin
---
hshassets/views.py | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/hshassets/views.py b/hshassets/views.py
index bf350aad..af03c771 100644
--- a/hshassets/views.py
+++ b/hshassets/views.py
@@ -1,24 +1,24 @@
-from django.urls import reverse, resolve
+from typing import Optional
+
+from django.urls import resolve, reverse
from django.views.generic.base import ContextMixin
class BreadCrumbMixin(ContextMixin):
-
- breadcrumb_parent = None
- breadcrumb_name = None
+ breadcrumb_parent = None # type: Optional[str]
+ breadcrumb_name = None # type: str
def get_breadcrumb_path(self, breadcrumb_path, url_name=''):
-
if self.breadcrumb_parent:
parent_view_class = resolve(reverse(self.breadcrumb_parent)).func.view_class
breadcrumb_path.extend(parent_view_class().get_breadcrumb_path(breadcrumb_path, self.breadcrumb_parent))
return breadcrumb_path + [{'name': self.breadcrumb_name, 'url': reverse(url_name) if url_name else '#'}]
- def get_context_data(self, *args, **kwargs):
+ def get_context_data(self, **kwargs):
assert self.breadcrumb_name, 'Missing attribute "breadcrumb_name" on {}'.format(self.__class__)
- context = super().get_context_data(*args, **kwargs)
+ context = super().get_context_data(**kwargs)
context.update({
'breadcrumb_path': self.get_breadcrumb_path([])
})
--
GitLab